Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532402 --- Comment #2 from Mark McKinstry <mmckinst@xxxxxxxxxxx> 2009-11-20 14:19:30 EDT --- (In reply to comment #1) Thanks for taking the time to look at my first package. > 1. The package didn't build on my system due to permissions on directories on > /etc/apf Fixed. > 2. rpmlint has a few messages: Fixed. > 3. Your buildroot is probably fine, but Fedora does have preferences, please > use a buildroot from: > https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Fixed. > 4. source0 should be URL to source file, please see: > https://fedoraproject.org/wiki/Packaging:SourceURL Unfortunately the author does not provide a way to download a specific version, you can only download the latest -current. I've added a note to the spec file explaining the situation. > 5. Add a version to the last changelog entry Done. The updated SPEC and SRPM are at: http://mmckinst.nexcess.net/apf/apf.spec http://mmckinst.nexcess.net/apf/apf-9.7.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review