Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538673 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-11-19 06:14:44 EDT --- oops while working on this review I guess Jim already took this. Anyway here is my review work Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1815778 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 75e9d6f79a321a62497f1808db35a1b52b7ba765 libunistring-0.9.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + %clean is present. + package installed properly. + Package contains code, not content. + no .pc file present. + -devel subpackage present. + no .la files. + no translations are available + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Package libunistring-0.9.1-1.fc13.i686 => Provides: libunistring.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libunistring.so.0 rtld(GNU_HASH) + Package libunistring-devel-0.9.1-1.fc13.i686 => Requires: libunistring.so.0 + Not a GUI application Suggestions: 1) you can simply write description for -devel package as Development files for programs using libunistring. 2) to preserve timestamps of upstream files that are copied as it is use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 3)defattr for devel should be %defattr(-,root,root,-) 4) Good if you follow same way of writing macros as defined at https://fedoraproject.org/wiki/Packaging/RPMMacros though %_libdir is same as %{_libdir} 5) Use scriptlet format given at https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo including changing Requires also. 6) I don't see any use of including Requires: pkgconfig for -devel package. Please remove it. 7) you don't need BuildRequires: automake libtool remove them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review