Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kphotobymail - Kphotobymail is a PyQT based application for uploading photos to flickr account. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208436 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From tcallawa@xxxxxxxxxx 2006-09-29 13:10 EST ------- A few things need to be fixed here: You need to add: BuildRequires: desktop-file-utils Upstream source does not match source in SRPM, you need to reconcile that: ecfa19fa8618da1314b3964f3d4b39c731e3d1ee kphotobymail-0.3.2.tar.gz.UPSTREAM 70cf51f8641f315b0b6f738c0740a351fe5eb912 kphotobymail-0.3.2.tar.gz Don't use the name of the program in the summary. A recommended change: Summary: A PyQT based application for uploading photos to flickr Also, while not mandatory, I highly recommend that you append %{?dist} to the end of the Release string. See http://fedoraproject.org/wiki/Packaging/DistTag Good: - rpmlint checks return: W: kphotobymail conffile-without-noreplace-flag /etc/kphotobymail.data Should be safe to ignore. E: kphotobymail non-executable-script /usr/lib/python2.4/site-packages/Kphotobymail/__init__.py 0644 Should be safe to ignore. W: kphotobymail mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 4) Just fix line 14 to use tabs instead of spaces. - package meets naming guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - desktop file ok Bad: - source does NOT match upstream Fix the blockers and I'll revisit this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review