Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=538046 --- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> 2009-11-18 04:46:34 EDT --- > Package doesn't contains a verbatin copy ot the license > text (No blocker, but please contact upstream to include > one into the upstream package) Since I'm part of upstream, I added it there. I also changed license to GPL2 and Python (been notified yesterday in review 491088). > Please use %global instead of %define Done > We prefer %defattr(-,root,root,-) Done. > question: Who should ownd %{rhnroot} rhn-client-tools. Added to Requires. Nice catch. > and %{rhnroot}/certs This package should. Done. Updated SPEC: http://miroslav.suchy.cz/fedora/spacewalk-certs-tools/spacewalk-certs-tools.spec Updated SRPM: http://miroslav.suchy.cz/fedora/spacewalk-certs-tools/spacewalk-certs-tools-0.7.2-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review