Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526126 --- Comment #46 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2009-11-17 15:52:43 EDT --- I read through the history here, and tried to summarize the remaining review issues. Here's what I think remains: - a reviewer needs to go through the full review guidelines on this - fixup the factual errors in the comment describing redefinition of __os_install_post - perhaps fixup rpm-build to avoid needing find-provides-without-python-sonames.sh - fixup macros.python3 to bake in the definitions, avoid invoking python3 each time - verify the script in comment #17 still works and that it verifies the 2 and 3 packages are independent - cosmetic issue: exec vs find | xargs noted in comment #36 - what files are affected when modifying shebangs, and how (see commment #39) - anything else I've missed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review