Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=534061 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #6 from Steve Traylen <steve.traylen@xxxxxxx> 2009-11-17 13:52:00 EDT --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1812747 Review of hostname: yes: rpmlint $ rpmlint hostname.spec ../SRPMS/hostname-3.01-1.fc13.src.rpm ../RPMS/x86_64/hostname-*fc13* hostname.spec: W: no-cleaning-of-buildroot %install hostname.spec: W: no-buildroot-tag hostname.src: W: no-cleaning-of-buildroot %install hostname.src: W: no-buildroot-tag 3 packages and 1 specfiles checked; 0 errors, 4 warnings. which are fine as explained in Comment #2. yes: Package is named well. yes: spec file name good. yes: meets packaging guidelines. yes: packge marked as GPLv2+ yes: source matches GPLv2+ yes: COPYRIGHT file included. yes: spec in english. yes: spec legible. yes: $ md5sum /tmp/hostname_3.01.tar.gz ~/rpmbuild/SOURCES/hostname_3.01.tar.gz 866c4250583960bf730fb7a8815dbb03 /tmp/hostname_3.01.tar.gz 866c4250583960bf730fb7a8815dbb03 /home/steve/rpmbuild/SOURCES/hostname_3.01.tar.gz yes: compiles, see koji build above. yes: compiles for all arches, see koji. yes: build deps sane, there are none. yes: no localles present. yes; contain no libraries. yes: not relocatable. yes: Everything in /bin doc or a man. Yes: Does not create any directories. yes: no file duplicates. yes: All fikes are %defattr. yes: clean buildroot on %clean. yes: macro use consistant. yes: Contains the hostname command. yes: no large docs. yes: docs not needed. yes: no header files. yes: no pkgconfig files. yes: no .so files anyway. yes: no devel packaes. yes: no .la files. yes: no gui present. yes: does share files with net-tools < 1.60-99 but has an explictit Conflicts: net-tools < 1.60-99 this is intentional and justified. yes: %install does not need rm -rf with this new rpm. yes: valid utf8. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review