Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532521 Guido Grazioli <guido.grazioli@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guido.grazioli@xxxxxxxxx --- Comment #6 from Guido Grazioli <guido.grazioli@xxxxxxxxx> 2009-11-17 11:04:45 EDT --- Is the jboss stuff relevant in Fedora or just a jpackage feature? I think you should at least enclose the repolib package building inside a conditional, or drop it. About maven, are you missing the installation of the pom file? (is maven used at all in building?). Other notes: - change %define-s with %global-s - you are missing BuildRequire: java-devel and Require: java - better use name and version macros in Source0 - is there a reason why you dont run junit tests? - -repolib subpackage should not own %{_javadir}/repository.jboss.com , but %{repodir} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review