Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537631 --- Comment #2 from Peter Robinson <pbrobinson@xxxxxxxxx> 2009-11-16 18:19:40 EDT --- (In reply to comment #1) > Before I do the full review here are some issues I've seen so far: > > 1. the Source0 URL seems to be not working, the server returns "404 Not found" > (probably we should ask upstream to tag the releases in git ;-) ) Yes, your correct. See the two lines at the top of the spec file to create the tar file. > IMHO it would be better to use only the file name as Source0 (the complete URL > could be kept in a comment for later when upstream has tagged the releases) - > otherwise it is misleading... Yes, I meant to update it as that URL is in my Moblin spec template. > 2. it looks like that the BR xulrunner-devel is not needed Oh! > 3. are you planning to package the moblin web browser as well? In this case I > would recommend that moblin-panel-web requires the moblin-web-browser > (otherwise it just won't do anything... ;-) ) Yes, Its in progress and I believe in the mean time it will use the default browser instead so in the short term it will still be useful when used with Firefox. > 4. regarding the License I'm not sure: the sources in common/ are LGPLv2.1 but > the main application seems to be GPLv2+ - I've asked on the fedora-legal > mailing list for clarification... I'll clarify with upstream. I looked in common and what was in the upstream Moblin specfile. I suspect its a mix of both because of what the other moblin-panel packages use. > I'm really looking forward to get a full moblin UI for Fedora! ;-) Me too! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review