Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509965 Ville Skyttä <ville.skytta@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ville.skytta@xxxxxx Flag| |fedora-review? --- Comment #12 from Ville Skyttä <ville.skytta@xxxxxx> 2009-11-16 12:36:37 EDT --- (In reply to comment #10) > http://giesen.fedorapeople.org/snmptt/snmptt-1.3-0.1.beta2.fc11.src.rpm Version 1.3 was released yesterday it seems. Anyway here's a partial review from skimming the above beta2 specfile, will complete the review when the package has been updated to 1.3: - Summary isn't very helpful wrt. what the package does. In my package I used "SNMP Trap Translator" which isn't perfect but IMO slightly better the current one. - %description doesn't actually describe snmptt but snmptrapd. In my snmptt package I had this: SNMPTT (SNMP Trap Translator) is an SNMP trap handler written in Perl for use with the Net-SNMP / UCD-SNMP snmptrapd program. It can be used to translate trap output from snmptrapd to more descriptive and human friendly form, supports logging, invoking external programs, and has the ability to accept or reject traps based on a number of parameters. - A number of installed files that contain hardcoded paths are installed using macros. This is a non-blocker as far as this review is concerned, however I'd recommend either using those hardcoded paths in the specfile or implementing something to replace those hardcoded paths in installed files with the expansions of macros. - snmptthandler is installed as %{_sbindir}/snmptthandler, %{_bindir}/snmpttconvert, and %{_bindir}/snmpttconvertmib which doesn't look right to me. - %post and %preun are not guarded for non-zero exit status See my old package in comment #3, it has fixes/improvements for all of the above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review