Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517743 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cwickert@xxxxxxxxxxxxxxxxx --- Comment #6 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2009-11-15 14:47:39 EDT --- (In reply to comment #5) > Issues: > - .desktop file needs Encoding=UTF-8 if you want to ship this into RHEL. > (at least desktop-file-validate fails without this, desktop-file-install > probably too) Just for fedora, this is not needed. And should not be there in fact. An easy way to achieve this is to have the Encoding in the desktop file and remove it if it's installed in Fedora: desktop-file-install --dir=$RPM_BUILD_ROOT%{_datadir}/applications \ %if 0%{?fedora} >= 10 --remove-key=Encoding \ %endif %{SOURCE1} BTW: /usr/share/ is hardcoded in the desktop file, you should at least use sed to make sure it is always correct. And please preserve timestamps during cp. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review