Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517366 --- Comment #25 from Arun SAG <sagarun@xxxxxxxxx> 2009-11-14 22:51:59 EDT --- (In reply to comment #24) > I think it is better just to move haskell-mode-init.patch > into "Source1: haskell-mode-init.el" - doing it as a patch > doesn't really make sense. Moved the haskell-mode-init.patch to source1 SPEC : http://sagarun.fedorapeople.org/SPECS/emacs-haskell-mode.spec SRPM : http://sagarun.fedorapeople.org/SRPMS/emacs-haskell-mode-2.5.1-2.fc11.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1807135 > > Have you submitted the Makefile patch upstream - it looks > pretty sane and non-fedora specific to me. > Not submitted, but asked the maintainer about the Makefile his reply was "> I tried to package emacs-haskell-mode addon ( > http://www.iro.umontreal.ca/~monnier/elisp/haskell-mode.tar.gz ), when i > examined the Makefile, it didn't really compile haskell-ghci.el and > haskell-hugs.el. Is there any specific reason for not compiling those files? They're obsolete, only left there for those few people who insist on using them." I will send the patch to the maintainer. > Otherwise I think the package looks pretty reasonable to me. > https://fedoraproject.org/wiki/Packaging:Emacs#Template_for_a_add-on_package_for_GNU_Emacs_only Thanks for the review, hope someone sponsors this package ; -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review