Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532309 Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(kanarip@xxxxxxxxx | |om) | --- Comment #3 from Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> 2009-11-14 14:55:37 EDT --- (In reply to comment #1) > - The srpm name must be "rubygem-ruby-net-ldap", not "rubygem-net-ldap" > ( even if the name seems rather redundant ), because > * the installed gem name is actually "ruby-net-ldap", not "net-ldap" > ( actually "gem list -b foo" or ruby -e "require 'rubygems' ; gem 'foo'" > shows it ). > Removing ruby- part from srpm is more confusing. > Fixed. > - Please use the defined macro and remove unused macro definition. > Fixed. > - Usually gems' source URL are: > http://gems.rubyforge.org/gems/<gemname>-<version>.gem > Fixed. > - Mark document files as %doc properly > > - Please enable test program. These tests will mostly fail because; 1) there isn't any adequate testing 2) tests do not have an LDAP server to connect to I enabled them anyway and made sure they would hold back the rpm build New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-ruby-net-ldap.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-net-ldap-0.0.4-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review