Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508518 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-11-14 13:17:41 EDT --- Review: - Sources match upstream - $ rpmlint meiga.spec meiga-0.3.1-1.fc12.src.rpm x86_64/meiga-0.3.1-1.fc12.x86_64.rpm x86_64/meiga-debuginfo-0.3.1-1.fc12.x86_64.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings. - file permissions ok - %files section ok - properly install locales - license GPLv2+ ok - package works as expected Issues: - Gnome users are currently forced to install kde-filesystem. If you split the .desktop files for kde into a subpackage, this would help a lot. But this is no requirement. - When installing there is a gtk-update-icon-cache: No theme index file. Don't not how to eliminate this, but not a blocker atm. - When building, there is a intltoolize: 'po/Makefile.in.in' exists: use '--force' to overwrite So please add --force to intltoolize This are only minor issues, so this package is: ___________________________ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review