Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530301 --- Comment #14 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-11-14 12:23:42 EDT --- Well, still I cannot launch bmpanel2 on GNOME, it launches on XFCE, so I will continue this review request. For -0.4: * Source - For source, please write the URL of the original source as a comment, and rename the stripped tarball to like "%{name}-%{upstream_version}-stripped.tar.gz" or so. * icon cache updating - Please follow https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache ( You are using the old template ) - As you are using %{_datadir}/icons/gnome/ (not %_datadir/icons/hicolor), the scriptlet should also be using this directory. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review