Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533738 --- Comment #6 from Scott Collier <boodle11@xxxxxxxxx> 2009-11-13 09:14:19 EDT --- (In reply to comment #5) > (In reply to comment #4) > > Thanks for help. Fixed that, hope it's fine now. > > works for me now. One more thing, in your spec file you have % files listed > twice: > > %files > %defattr(-,root,root,-) > %doc COPYING NEWS ChangeLog > %{_bindir}/* > > %files devel > %defattr(-,root,root,-) > %{_includedir}/* > > > You can get rid of one and compress it down to: > > %files > %defattr(-,root,root,-) > %doc COPYING NEWS ChangeLog > %{_bindir}/* > %{_includedir}/* > Sorry, missed the %files devel tag, nevermind the comment above. %files devel is fine. That just leaves the rpmlint warning. > rpmlint has one more trivial warning: > > $ rpmlint bwa.spec > bwa.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab: line 1) > 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > > Go ahead and fix that, then I think you are good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review