Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-bogofilter - A plugin for bogofilter support in evolution https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207806 ------- Additional Comments From kevin@xxxxxxxxx 2006-09-28 23:03 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 668f11a7f04a1af32b1077420854bd98 bf-eplugin-0.2.0.tar.gz 668f11a7f04a1af32b1077420854bd98 bf-eplugin-0.2.0.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: See below - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. rpmlint says: W: evolution-bogofilter no-url-tag W: evolution-bogofilter no-documentation W: evolution-bogofilter non-conffile-in-etc /etc/gconf/schemas/bf- eplugin.schemas 2. Might include the following as %doc files? AUTHORS ChangeLog COPYING NEWS README 3. Might change defattr from %defattr(-,root,root) to %defattr(-,root,root,-) 4. I suppose it makes sense to call this evolution-bogofilter instead of the upstream name of bf-eplugin. Perhaps upstream could even be talked into changing the name there? no one is going to know they should look for bf-eplugin for this IMHO. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review