Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=536718 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |nicolas.mailhot@xxxxxxxxxxx Flag| |fedora-review?, | |needinfo?(tcallawa@xxxxxxxx | |om) --- Comment #1 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2009-11-13 06:03:02 EDT --- Hey, Nice to see you packaging some fonts again. Review: 1. (nitpick) the exact term for "accent marks" is diactritics (includes stuff like cedilla which is not strictly speaking an accent mark) 2. repo-font-audit found some partial coverage, and that rpmlint is not completely happy with the font (to relay upstream, see attached archive) 3. (nitpick) you don't really need to define a common_desc when there's only one package produced. It's useful for multi-subpackages 4. Please check with upstream they'll actually increment the version next time the font is updated. If 1.000 is an eternal unchanging version, using the timestamp of the font file as version is more useful. 5. You forgot the Requires: fontpackages-filesystem ⇒ fails review :( 6. Not too sure looping on one fontconf file is useful 7. Maybe it would be a good idea to bundle the licensing email as %doc ? Some old font packages did this and it's invaluable when all the web references have moved 20 times since packaging 8. There is no licensing info, either as detached txt file, or as metadata in the font (just confirming your finds). Doing both is best 9. This is not really a general-purpose sans-serif font, please change your fontconfig file (see /usr/share/fontconfig/templates/fontconfig-generics.txt and /usr/share/fontconfig/templates/basic-font-template.* ) ⇒ Needs a little more work, even though it's already a pretty nice srpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review