Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531541 Mark McLoughlin <markmc@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markmc@xxxxxxxxxx --- Comment #8 from Mark McLoughlin <markmc@xxxxxxxxxx> 2009-11-13 05:01:19 EDT --- This looks mostly fine to me, with the exception that python packages must now package eggs if they're built: https://fedoraproject.org/wiki/Packaging/Python/Eggs Also, you can drop the -O1 arg to 'setup.py install', the .pyo files are automatically generated Attaching a patch to fix those and a couple of other trivial things Other things checked: - rpmlint passes with no warnings/errors - adheres to python packaging guidelines - basic package meta-data is correct - source url is correct - both BuildRequires are actually required - can't see any missing BuildRequires - ditto for Requires - all requires are available in Fedora - build procedure is correct - .pyc and .pyo files are packaged, as per guidelines - all dirs are packaged - %changelog format is correct - etc. etc. I'd be happy to give this a fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review