Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530688 Bryan O'Sullivan <bos@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bos@xxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #2 from Bryan O'Sullivan <bos@xxxxxxxxxxxxxx> 2009-11-13 00:28:45 EDT --- MUST: rpmlint must be run on every package. $ rpmlint ghc-language-c-devel-0.3.1.1-1.fc11.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-language-c-doc-0.3.1.1-1.fc11.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-language-c-prof-0.3.1.1-1.fc11.x86_64.rpm ghc-language-c-prof.x86_64: E: devel-dependency ghc-language-c-devel ghc-language-c-prof.x86_64: W: no-documentation ghc-language-c-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.10.3/language-c-0.3.1.1/libHSlanguage-c-0.3.1.1_p.a 1 packages and 0 specfiles checked; 1 errors, 2 warnings. OK. All expected. MUST: The package must be named according to the Package Naming Guidelines. OK. MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK. MUST: The package must meet the Packaging Guidelines. OK. MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK. MUST: The License field in the package spec file must match the actual license. OK. MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK. MUST: The spec file must be written in American English. OK. MUST: The spec file for the package MUST be legible. OK. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK. MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK. MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. OK. MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. OK. MUST: The spec file MUST handle locales properly. NA. MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. NA. MUST: Packages must NOT bundle copies of system libraries. NA. MUST: If the package is designed to be relocatable,... NA. MUST: A package must own all directories that it creates. OK. MUST: A Fedora package must not list a file more than once in the spec file's %files listings. OK. MUST: Permissions on files must be set properly. OK. MUST: Each package must have a %clean section OK. MUST: Each package must consistently use macros. OK. MUST: The package must contain code, or permissable content. OK. MUST: Large documentation files must go in a -doc subpackage. OK. MUST: If a package includes something as %doc, it must not affect the runtime of the application. OK. MUST: Header files must be in a -devel package. NA. MUST: Static libraries must be in a -static package. NA. MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). NA. MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1) NA. MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} OK. MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. OK. MUST: Packages containing GUI applications must NA. MUST: Packages must not own files or directories already owned by other packages. OK. MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK. MUST: All filenames in rpm packages must be valid UTF-8. [27] OK. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review