Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531773 Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> 2009-11-12 21:45:50 EDT --- (In reply to comment #4) > Thanks for the review: > > (In reply to comment #3) > > - $ rpmlint rpmbuild/SRPMS/synfig-0.61.09-4.fc11.src.rpm synfig.src: W: > > mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 64) > > Fixed. (This tiny change being the only one, I did not bump a release number.) > > - Missing %{name}.desktop file because synfig is a GuI application > > It's not, please read the description. synfigstudio is, see bug #479527 Ok. I am also talikg synfigstudio for review as well. > > checking how to run the C++ preprocessor... /lib/cpp > > configure: error: in `/home/luya/rpmbuild/BUILD/synfig-0.61.09': > > configure: error: C++ preprocessor "/lib/cpp" fails sanity check > > See `config.log' for more details. > > error: Bad exit status from /var/tmp/rpm-tmp.WcYKNa (%build) > > That's probably you don't have the build group installed [1] (presumably the > cpp package). Either install it, or use mock to do the build. > It was gcc-c++ package that was not installed although it should with the use of yum-builddep command with src package (might be a bug but it is another story). Back to the review: + $ rpmlint Downloads/synfig-0.61.09-4.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. + md5sum rpmbuild/SOURCES/synfig-0.61.09.tar.gz Downloads/synfig-0.61.09.tar.gz 0330521fe46b9e8a39df7081ec64c5d5 rpmbuild/SOURCES/synfig-0.61.09.tar.gz 0330521fe46b9e8a39df7081ec64c5d5 Downloads/synfig-0.61.09.tar.gz + sha512sum rpmbuild/SOURCES/synfig-0.61.09.tar.gz Downloads/synfig-0.61.09.tar.gz 799c076a2ba8d00b02273ee191421ffb2379081107b1d5e101db010bb0c347ea75e89ba17891fe367f0fe2d7bb979e7660317240afb402fe11147c268c0592ea rpmbuild/SOURCES/synfig-0.61.09.tar.gz 799c076a2ba8d00b02273ee191421ffb2379081107b1d5e101db010bb0c347ea75e89ba17891fe367f0fe2d7bb979e7660317240afb402fe11147c268c0592ea Downloads/synfig-0.61.09.tar.gz + Source package succesfully built on all architecture using Koji and also built locally In conclusion, the package fully complies with packaging guideline. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review