Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465159 --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-11-12 19:50:41 EDT --- Wow, this is ancient. Are you still interested in contributing this package? If so, here are a few comments: I note that the current version has a significantly larger version number, which is not surprising. The selinux subpackage is going to be scary for most reviewers; I certainly don't feel qualified to review it. Have the selinux folks (dwalsh, etc.) had a look at your policy? I have significant doubts about files in /usr/share being configuration files. Group is completely unimportant; put whatever you want there. The proper way to classify such applications is using comps. If tcpdf.org is actually a separate package (separate tarball, differing release cycle), it cannot be bundled as part of this one. The fonts cannot be bundled; they must be packaged (if they aren't already) and the code must use the packaged versions. Don't try to output information in scriptlets; you can't expect that it will be seen by anyone. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review