Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504891 Guido Grazioli <guido.grazioli@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guido.grazioli@xxxxxxxxx --- Comment #4 from Guido Grazioli <guido.grazioli@xxxxxxxxx> 2009-11-10 19:37:09 EDT --- I'm interested in this package, Jerry are you still working on it? Some quick things: - renaming to trove4j seems reasonable (other distros did that also) - prefer %global over %define - group Development/Libraries/Java is not standard, change it to Development/Libraries - -javadoc subpackage should Requires: jpackage-utils too - would packaging lastest stable ver 2.1.0 be feasible? - as per gcj guidelines, in %%files: %if %{with_gcj} - %{_libdir}/gcj/%{name} + %attr(-,root,root) %{_libdir}/gcj/%{name} %endif -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review