Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491497 --- Comment #7 from Christian Krause <chkr@xxxxxxxxxxx> 2009-11-10 18:27:02 EDT --- Before I do the full review here are some issues which should be fixed before: 1. does not build if dbus-devel is not installed - please add it to the build requires (and probably to the configure script ;-) ) 2. lots of warnings when using rpmlint: rpmlint SPECS/dmapd.spec RPMS/i686/dmapd-* SRPMS/dmapd-0.0.14-1.fc12.src.rpm dmapd.i686: W: conffile-without-noreplace-flag /etc/sysconfig/dmapd dmapd.i686: W: devel-file-in-non-devel-package /usr/lib/dmapd/0.0.14/modules/libdb-gdir.so dmapd.i686: W: devel-file-in-non-devel-package /usr/include/dmapd-dpap-record.h dmapd.i686: W: devel-file-in-non-devel-package /usr/include/dmapd-daap-record.h dmapd.i686: W: devel-file-in-non-devel-package /usr/lib/pkgconfig/dmapd.pc dmapd.i686: W: non-standard-uid /var/run/dmapd dmapd dmapd.i686: E: non-standard-dir-perm /var/run/dmapd 0700 dmapd.i686: E: postin-without-ldconfig /usr/lib/libdmapd.so.0.0.0 dmapd.i686: E: postun-without-ldconfig /usr/lib/libdmapd.so.0.0.0 dmapd.i686: W: non-standard-uid /var/cache/dmapd dmapd dmapd.i686: E: non-standard-dir-perm /var/cache/dmapd 0700 dmapd.i686: W: devel-file-in-non-devel-package /usr/lib/libdmapd.so dmapd.i686: E: executable-marked-as-config-file /etc/sysconfig/dmapd dmapd.i686: E: script-without-shebang /etc/sysconfig/dmapd dmapd.i686: W: percent-in-%pre dmapd.i686: W: percent-in-%postun dmapd.i686: W: dangerous-command-in-%postun userdel 3 packages and 1 specfiles checked; 6 errors, 11 warnings. There are some false positives, but at least the devel-file-in-non-devel-package should be fixed first. Please create either a -devel subpackage or delete the devel files in the %install section if it is not intended to build something based in libdmapd.so. 3. /etc/sysconfig/dmapd should not be executable 4. add ldconfig to %post and %postun 5. I have to second Fabian's request to enhance the formatting of the spec file: - there are lots of unneeded empty lines - the order of the main sections is unusual, e.g. %doc is not directly after %files, but somewere later in the file - the scriptlets in the %preund and %postun sections are squeezed into single lines which makes them hard to read / verify Probably you can enhance/tweak the tool which generates the spec file a little bit. ;-) 6. the way of creation/deletion of the user and groups is not the official one (and it doesn't work at all) rpm -U ~rpmbuild/RPMS/i686/dmapd-0.0.14-1.fc12.i686.rpm /var/tmp/rpm-tmp.K6nmcB: line 1: fg: no job control /var/tmp/rpm-tmp.K6nmcB: line 2: fg: no job control warning: user dmapd does not exist - using root warning: user dmapd does not exist - using root rpm -e dmapd /var/tmp/rpm-tmp.RHEC9n: line 2: fg: no job control /var/tmp/rpm-tmp.RHEC9n: line 3: fg: no job control /var/tmp/rpm-tmp.RHEC9n: line 5: fg: no job control warning: %postun(dmapd-0.0.14-1.fc12.i686) scriptlet failed, exit status 1 Please change it according to http://fedoraproject.org/wiki/Packaging:UsersAndGroups (which is the official specification). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review