Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530301 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx Blocks| |182235(FE-Legal) --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-11-10 13:58:23 EDT --- Well, * License - The following files (and perhaps the image files in the same directories) are under CC-BY-NC-SA, which is not accepted. https://fedoraproject.org/wiki/Licensing#Bad_Licenses_3 ------------------------------------------------------------------- CC-BY-NC-SA: ./themes/alduin-glossy/theme ./themes/alduin-smooth/theme ./themes/auriel-blue-opaque/theme ./themes/auriel-blue-smooth/theme ./themes/auriel-green-opaque/theme ./themes/auriel-green-smooth/theme ./themes/auriel-pink-opaque/theme ./themes/auriel-pink-smooth/theme ./themes/curvy-blue/theme ./themes/curvy-green/theme ./themes/curvy-pink/theme ./themes/flora-blue/theme ./themes/flora-green/theme ./themes/flora-pink/theme ./themes/striped/theme -------------------------------------------------------------------- First please remove these files from tarball. see: https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code Also it is highly recommended to contact the upstream. Then some notes * Requires - "Requires: pango cairo" are redundant and should be removed, because these library related dependencies are automatically detected by rpmbuild itself and these dependencies are added to the rebuilt binary rpm. - Also "Requires: python" is unneeded because python(abi) dependency is automatically added (but please also see below) - For python related packages, please check the dependency for python-module related rpm by yourself. For example, /usr/bin/bmpanel2cfg contains: --------------------------------------------------------------------- 3 import bmpanel2 4 import gtk, gobject 5 from gtk import gdk --------------------------------------------------------------------- This means that -cfg package should have "Requires: pygtk2". * %changelog - As it is convenient when using Fedora CVS, it is recommended that you add one line between each %changelog entry like: --------------------------------------------------------------------- * Mon Nov 09 2009 Marcus Moeller <mmoeller@xxxxxxxxxxxxxxxxx> - 2.1-0.2.pre1 - Added python-devel build requirement - Fixed docbook stylesheet reference * Fri Nov 06 2009 Marcus Moeller <mmoeller@xxxxxxxxxxxxxxxxx> - 2.1-0.1.pre1 - Updated to upstream version 2.1pre1 - Seperated cfg package * Thu Oct 20 2009 Marcus Moeller <mmoeller@xxxxxxxxxxxxxxxxx> - 2.0.1a-1 - Initial Release --------------------------------------------------------------------- For now, blocking FE-Legal. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review