Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524379 --- Comment #20 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-11-10 13:19:27 EDT --- (In reply to comment #19) > (In reply to comment #18) > > > As I said above currently all python package on Fedora is >= 2.0 (in fact > > > >= 2.5.2), so this is just redundant. > > I had initially not written version of python-devel in spec file, later I was > later suggested to write the version. So should I remove the version of > python-devel from the spec file? - I suggest to remove this. Guidelines related to this: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires ------------------------------------------------------------ For instance in the example above, when no current Fedora release shipped with libfubar < 1.2.3-7, it is no longer necessary to list the explicit, versioned requirement. ------------------------------------------------------------ (In reply to comment #18) > I have fixed all the issues discussed in earlier messages. - Please fix this (the following comments are from me) (In reply to comment #7) > Some notes: > * Requires > - Please check the dependency for python module related packages (this > cannot be detected automatically by rpmbuild and you have to investigate > this manually by yourself). > ! Example > /usr/bin/gscribble contains: > --------------------------------------------------------------------- > 16 try: > 17 import pygtk > 18 pygtk.require('2.0') > 19 except: > 20 print "Install PyGtk >= 2.0." > 21 sys.exit(1) > --------------------------------------------------------------------- > This means that this package should have "Requiers: pygtk2". Note that here I am talking about "Requires", not "BuildRequires". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review