Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: HelixPlayer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=201006 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2006-09-28 14:37 EST ------- Suggestions: 1. Make buildable everywhere -BuildRequires: libogg-devel, libXt-devel, libXv-devel +BuildRequires: libogg-devel BuildRequires: desktop-file-utils +%if "%{?fedora}" > "4" || "%{?rhel}" > "4" +BuildRequires: libXt-devel libXv-devel +%else +BuildRequires: xorg-x11-devel +%endif 2. Drop Requires: libbluecurve hack 3. -plugin should Requires: %{name} = %{version}-%{release} 4. drop deprecated use-of/references-to %_datadir/pixmaps 5. in %install, recommend using the 'install -p' command in place of 'cp', be careful in most places to use -m644, but for bins/libs use -m755 Address these, and I'll approve this. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review