Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2009-11-09 15:18:00 EDT --- 1) What's the reason for the Provides: CGSI_gSOAP = %{version}-%{release} Obsoletes: CGSI_gSOAP < 1.3.2.2-3 where was CGSI_gSOAP released? 2) I read in another review that %{_docdir}/%{name}-devel-%{version} should not be marked as a %doc but only the items inside it though to be honest it makes more sense to me if it is a %doc to be left out upon installing with no %docs. 3) Given the cvs tag is a date should the release number not reflect this? http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages Other than that looking good. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review