Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516312 Hicham HAOUARI <hicham.haouari@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(hicham.haouari@gm | |ail.com) | --- Comment #5 from Hicham HAOUARI <hicham.haouari@xxxxxxxxx> 2009-11-08 16:08:03 EDT --- 1. Origin of the Name: >From Fedora Package Guidelines : http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Binary_Firmware "Firmware packages must be named <foo>-firmware, where <foo> is the driver or other hardware component that the firmware is for." The driver name is ueagle-atm, the number 4 because this firmware is for Chipset 4. 2.Summary is inconsistent with description : Fixed 3.Missing Requires: udev for ownership of /lib/firmware : Fixed 4.Unowned directory /lib/firmware/ueagle-atm : Fixed 5.Inconsistent macro usage (%{buildroot} vs. $RPM_BUILD_ROOT) : Fixed 6.cp -rf -p <- surely cp -p is enough? : fixed 7. Fedora Legal status : Fixed in comment 3 Spec URL : http://hicham.fedorapeople.org/ueagle-atm-firmware4.spec SRPM URL : http://hicham.fedorapeople.org/ueagle-atm-firmware4-1.0-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review