[Bug 530756] Review Request: circuit_macros - A set of macros for drawing high-quality line diagram

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530756





--- Comment #8 from Ben Boeckel <mathstuf@xxxxxxxxx>  2009-11-08 09:53:51 EDT ---
(In reply to comment #7)
> #001: Requires
> 
> README states : 
> 
> REQUIRED SOFTWARE:
> Preferred setup:
>   m4, dpic (see below), TeX or LaTeX, PSTricks, dvips
Added dpic, tex(latex), texlive-texmf, and texlive-dvips.

> Update your Requires accordingly
> 
> #002: Requires of Sub package - examples
> 
> Requires:      %{name}
> should rather be 
> Requires:     %{name} = %{version}-%{release}
Fixed.

> #003: I think you are forgetting *.m4 found in the -doc directory.
See below.

> #004: 2 directories for documentation ?
> 
> The main package has /usr/share/doc/circuit_macros-6.61/ for its %doc
> 
> The sub package has /usr/share/doc/circuit_macros/examples for its %doc
> 
> I prefer that there is only ONE directory for ALL documentation. It is simply
> because while giving the user more examples cases, we should not drown the user
> into confusion.
Problem is RPM.

+ cd /home/boeckb/rpmbuild/BUILD
+ cd Circuit_macros6.61
+
DOCDIR=/home/boeckb/rpmbuild/BUILDROOT/circuit_macros-6.61-3.fc12.x86_64/usr/share/doc/circuit_macros-6.61
+ export DOCDIR
+ rm -rf
/home/boeckb/rpmbuild/BUILDROOT/circuit_macros-6.61-3.fc12.x86_64/usr/share/doc/circuit_macros-6.61

Anything I install to there is blown away when the main package grabs the files
from its %doc list. Any way to avoid this? See below for a possible workaround.

> #005: You are missing the subdirectories found in the examples directory.
> These should found their way to your -examples subpackage
> 
> #006: the *.tex from the examples should also be added to the -examples
> subpackage. It is an example (and source) how to use those symbols into one's
> latex document.
Would it just be easier to:
    %doc doc/ examples/
in this case?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]