Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529441 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #5 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-11-07 19:23:58 EDT --- I made the preliminary review on this package. It needs some work. I also need to see this building in koji in all archs before approving. * These need to be added otherwise, package will not build in mock and/or will have broken deps: BuildRequires: ant-nodeps BuildRequires: junit BuildRequires: jakarta-commons-logging Requires: jakarta-commons-logging export CLASSPATH=$( ... jakarta-commons-logging junit) You don't necessarily need "Requires: junit". See below. - Patches should be explained and be submitted to upstream. Since this is a pure Fedora specific patch we can ignore the upstream part. * rpmlint says: pdfbox.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/pdfbox-0.8.0/RELEASE-NOTES.txt This can be corrected in %prep easily via sed 's|\r||' or similar. pdfbox-javadoc.x86_64: W: non-standard-group Development Documentation Simply use "Documentation" pdfbox.src:120: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} This can be ignored. * This package includes fonts that are already available in Fedora. This is not allowed by the guidelines. You will need to patch the source to remove these fonts from the jar file and use the system ones instead. This will require adding Requires: bitstream-vera-sans-fonts See http://fedoraproject.org/wiki/Packaging:FontsPolicy ! It would be good to run the supplied tests in %check via "ant test". But for this, you may need to add BuildRequires(check): ant-junit and *possibly* add this to classpath before you call "ant test" ? Test classes are being packaged (they end up in the final jar). Is this necessary? If yes, then you will need to add Requires: junit If not sure, please contact upstream. ! %attr(-,root,root) is not needed as I explained in the previous review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review