Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533094 --- Comment #5 from Christian Krause <chkr@xxxxxxxxxxx> 2009-11-06 15:40:53 EDT --- (In reply to comment #3) Thank you very much for the detailed review. > Issues: > - in %files: %{_datadir}/applications is wrong, > should be %{_datadir}/applications/* > - a comment about the permissions would be good ;) (In reply to comment #4) > Forgot to add use %global and not %define: All mentioned issues are fixed in the new package: %changelog * Fri Nov 06 2009 Christian Krause <chkr@xxxxxxxxxxxxxxxxx> - 4.0.0-3 - Don't own /usr/share/applications - Fix permissions of man pages - Use %%global instead of %%define Spec URL: http://chkr.fedorapeople.org/review/xskat.spec SRPM URL: http://chkr.fedorapeople.org/review/xskat-4.0.0-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review