Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225785 --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-11-06 15:04:00 EDT --- Some other items, I just found: - DOES NOT BUILD IN KOJI: see below - macros in %changelog, %pre in line 2098 and %doc in line 2259 please use %%pre and %%doc instead - Prereq: /usr/sbin/useradd is deprecated: please use Requires: instead - 122 Obsoletes: fast-user-switch-applet 123 Provides: fast-user-switch-applet = %{epoch}:%{version}-%{release} Should that not be: Obsoletes: fast-user-switch-applet < %{epoch}:%{version}-%{release} ? - DOES NOT BUILD IN KOJI: http://koji.fedoraproject.org/koji/taskinfo?taskID=1792744 CC gdm-product-display.o CC gdm-manager.o CC gdm-slave-proxy.o sed -e 's,[@]sbindir[@],/usr/sbin,g' <./gdm.in >gdm CCLD gdm-simple-slave gdm-manager.c:36:1: warning: "DBUS_API_SUBJECT_TO_CHANGE" redefined <command-line>: warning: this is the location of the previous definition gdm-manager.c: In function 'gdm_manager_set_xdmcp_enabled': gdm-manager.c:299: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory' gdm-manager.c:301: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory' gdm-manager.c:305: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory' gdm-manager.c:308: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory' gdm-manager.c:309: error: 'GdmManagerPrivate' has no member named 'xdmcp_factory' make[3]: *** [gdm-manager.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory `/builddir/build/BUILD/gdm-2.28.1/daemon' make[2]: Leaving directory `/builddir/build/BUILD/gdm-2.28.1/daemon' make[2]: *** [all] Error 2 make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/gdm-2.28.1' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.laAClY (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.laAClY (%build) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review