Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tclabc - A Tcl interface and a Tk GUI to the ABC notation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207853 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-09-28 11:00 EST ------- Well, Reviewing this. 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Requires and BuildRequires - The following Requires/BuildRequires are not needed. * BuildRequires: tcl <- required by tk * BuildRequires: tk <- required by tk-devel * BuildRequires: tcl-devel <- required by tk-devel * Requires: tcl <- required by tk - The results of rebuilding this between by normal rpmbuild and by mockbuild differ * The comparison of what tclabc-1.0.7-1.fc6 requires between the one rebuild by rpmbuild and by mockbuild: --- 2.txt 2006-09-28 23:34:40.000000000 +0900 +++ 1.txt 2006-09-28 23:34:15.000000000 +0900 @@ -1,7 +1,5 @@ /bin/sh abcm2ps -libasound.so.2 -libasound.so.2(ALSA_0.9) libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) Build log also differ: ............. @@ -65,7 +341,7 @@ checking for dlopen in -ldl... yes checking for sound card... yes checking for SB AWE 32... yes -checking for the ALSA library... yes +checking for the ALSA library... no updating cache ./config.cache creating ./config.status creating Makefile ............. @@ -147,67 +424,69 @@ midi.c:2720: warning: ignoring return value of 'write', declared with attribute warn_unused_result gcc -shared tclabc.o abcparse.o change.o midi.o \ -o tclabc.so \ - -lasound + + exit 0 Check the BuildRequires dependency for alsa library. * Encoding - Some text files are encoded in ISO-8859-1 /usr/lib/tclabc/change.tcl /usr/lib/tclabc/detail.tcl /usr/lib/tclabc/help.tcl /usr/lib/tclabc/lang-de.tcl /usr/lib/tclabc/lang-fr.tcl /usr/lib/tclabc/lang-nl.tcl /usr/lib/tclabc/lang-ptBR.tcl /usr/lib/tclabc/lang-se.tcl /usr/lib/tclabc/play.tcl /usr/lib/tclabc/pref.tcl /usr/lib/tclabc/select.tcl /usr/lib/tclabc/tkabc.tcl /usr/lib/tclabc/tkorgan.tcl /usr/share/doc/tclabc-1.0.7/README * At least the encoding of /usr/share/doc/tclabc-1.0.7/README should be changed to UTF-8. * Also check if other tcl files can also have their encodings changed to UTF-8. * Timestamps - This package includes some html files in source files, so keeping timestamps for these html files are recommended. Use: make install prefix=....... INSTALL_DATA="install -c -p" to keep timestamps. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : * The sources used to build the package... Use: http://moinejf.free.fr/tclabc-%{version}.tar.gz for Source0 3. Other things I have noticed. * Well, I don't understand how to use this, however, when I try "tkabc bachto.mid" (bachto.mid is MIDI file), I get: [tasaka1@localhost TEMP]$ tkabc bachto.mid no output MIDI synth open: No such file or directory cannot open MIDI in '/dev/midi00' .. is this okay? It seems I cannot hear any sound. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review