Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530288 Peter Lemenkov <lemenkov@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #367803|application/octet-stream |text/plain mime type| | --- Comment #3 from Leon Keijser <keijser@xxxxxxxxxxxx> 2009-11-06 05:22:21 EDT --- Hi Mamoru, thanks for your notes. My comments are below, prefixed with '+': * EVR (Epoch-Version-Release) + fixed * License tag + fixed * SourceURL + fixed. Entire SourceURL pointed to the wrong address. * Seemingly unneeded files + fixed: i've removed them. Although now rpmlint complains about missing documentation. Shouldn't i at least include the README file? * Usability + fixed by adding an {__install} method to %install and including it in %files as %config(noreplace) %{_sysconfdir}/%{name}.conf Updated SPEC file is attached to this bug report (since github fails to recognize it as a new file and stupidly shows the older version). Updated SRPM: http://cloud.github.com/downloads/lkeijser/stonevpn/stonevpn-0.4.3-1.fc11.src.rpm Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review