Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533141 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-11-05 06:24:55 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1789541 - rpmlint is NOT silent for SRPM and for RPM. perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/README perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/META.json perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/dist.ini perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/LICENSE perl-CGI-Application-Plugin-DBIx-Class.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-CGI-Application-Plugin-DBIx-Class-0.093011/Changes + source files match upstream url fc3499c707002c21d1cc9008fcb49e9fe3140b2a CGI-Application-Plugin-DBIx-Class-0.093011.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=21, 2 wallclock secs ( 0.05 usr 0.01 sys + 0.79 cusr 0.04 csys = 0.89 CPU) + Package perl-CGI-Application-Plugin-DBIx-Class-0.093011-1.fc12.noarch => Provides: perl(CGI::Application::Plugin::DBIx::Class) = 0.093011 Requires: perl(Carp) perl(Exporter) perl(parent) perl(strict) perl(warnings) + Not a GUI application Suggestion: 1) Just add following line to %prep section sed -i 's/\r//' Changes LICENSE dist.ini META.json README This will fix rpmlint messages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review