Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533075 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-11-05 05:44:54 EDT --- Few notes: * I advice you to add the following line to the %prep section (to avoid copying firmware blobs directly into ~/rpmbuild/BUILD directory): %setup -c -T * Also, I advice you to fix line ending in LICENSE file in %prep section instead of fixing it in the %install section. * The file, with license, must not be placed in /lib/firmware. You must mark it as %doc instead. * Since you're using /lib/firmware/ then you should add "Requires: udev" (the owner of this directory). See rpm -qf /lib/firmware * No need to explicitly create "$RPM_BUILD_ROOT/lib/firmware" in your case. Just add -D switch to install command. * You're using %{__install} macro instead of plain "install". Why? I don't see any reasons to do so. This is not a blocker, actually - I just want to know :). Other things looks sane for me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review