Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526651 --- Comment #34 from Paulo Roma Cavalcanti <promac@xxxxxxxxx> 2009-11-04 11:26:30 EDT --- (In reply to comment #33) > Hmm, a few issues on a full review. > > One, they didn't update the GPL licensing text in all places, but that's OK > since the GPLv2 stuff says GPLv2+. Given that, might want to change license > tage to GPLv3+. Done, and there is a new version 2.8.7 available. > > Source URL should be Source0: > http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz, modified > for the project name. http://downloads.sourceforge.net/sf-xpaint/xpaint-2.8.7.tar.gz redirects to: http://sourceforge.net/projects/sf-xpaint/files/ > > Why is the URL tag pointing to the SF project, and not the SF web page? Because the SF web page does not have any downloadable link, as you can see: http://sf-xpaint.sourceforge.net/ It is kind of unusable, IMHO. > > Mock build and BRs are OK. > > I've also read this entire review and considered the issues raised and their > solutions. > > I think once the various tags above are fixed, I could approve. SPEC: http://orion.lcg.ufrj.br/RPMS/SPECS/xpaint.spec SRPM: http://orion.lcg.ufrj.br/RPMS/src/xpaint-2.8.7-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review