Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530473 --- Comment #6 from Michael Schwendt <mschwendt@xxxxxxxxx> 2009-11-04 06:41:20 EDT --- * The %description could be a bit more verbose than the %summary in explaining what this package supplies. * In the %summary it is good practise to not repeat %name and reduce the summary to headline/title-style: "Inline data deduplicating filesystem" > export CFLAGS="-ggdb2 -O2" No comment on why Fedora's global %optflags are not being used? > rm -rf %{buildroot}%{_datadir}/%{name} Such activity asks for a comment in the .spec file. > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig No shared library are included in this package. > %{_mandir}/man1/lessfs.1.gz Typically, the '*' wildcard is used instead of hardcoding the gzip compression suffix ".gz". That way rpmbuild may change the compression technique without requiring spec updates. > /etc/init.d/lessfs An initscript without corresponding chkconfig/service scriptlets in the .spec file? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review