Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532699 Xavier Bachelot <xavier@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2009-11-03 19:33:34 EDT --- > I still need to check the upgrade path. At least, I need to understand why 'yum > localinstall ClanLib1' doesn't try to remove the older ClanLib package. The > Obsoletes: look fine to me though. > Works fine when the package is in a local repo. > Nitpick, you might want to change the suffix for Source1 and Patch[01] from > ClanLib to ClanLib1 to avoid conflict with the files included in the current > current ClanLib package. Also, patches aren't referencing upstream bugs, as > required for some time by the guidelines. Don't know if it's a must or a > should, I need to check that too. This is a "should' APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review