Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516527 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steve.traylen@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review+ --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2009-11-03 17:19:30 EDT --- Review of globus-gass-server-ez: Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1786494 yes: rpmlint $ rpmlint SPECS/globus-gass-server-ez.spec \ RPMS/x86_64/globus-gass-server-ez-* \ SRPMS/globus-gass-server-ez-2.5-1.fc12.src.rpm globus-gass-server-ez-devel.x86_64: W: no-documentation globus-gass-server-ez-progs.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 0 errors, 2 warnings. yes: package named as per-globus. yes: spec file correct. yes: globus guidelines good. yes: ASL 2.0 in .spec yes: contents is also ASL 2.0 yes: GLOBUS_LICEENSE include. yes: english .spec yes: legible spec. yes: upstream matches. $ diff --recursive --brief globus_gass_server_ez-2.5 ~/globus/gt4.2.1-all-source-installer/source-trees/gass/server_ez/source/ Only in globus_gass_server_ez-2.5: GLOBUS_LICENSE which is expected. yes: compiles , see koji above. yes: builds on all archs. yes: builds on all archs. yes: build dependencies sane. yes: no locales anyway. yes: ldoconfig called correctly. yes: no statics. yes: owns all directories. yes: no duplicate files. yes: all %defattr. yes: %clean is cleaned. yes: contains code. yes: no large docs anyway. yes: doc not needed. yes: headers are in devel. yes: pkgconfig required. yes: devel does require base explicitly. yes: no gui. yes: owns all files or directories or pulls them in. yes: %install is cleaned. yes: utf8. yes it's a very boring package. APPROVED. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review