[Bug 525432] Review Request: openxcap - Fully featured XCAP server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=525432


Andrew Colin Kissa <andrew@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Andrew Colin Kissa <andrew@xxxxxxxxxxxxx>  2009-11-03 04:39:31 EDT ---
OK: rpmlint must be run on every package

rpmlint ~/rpmbuild/RPMS/noarch/openxcap-1.1.2-1.fc11.noarch.rpm
~/rpmbuild/SRPMS/openxcap-1.1.2-1.fc11.src.rpm 
openxcap.src: W: mixed-use-of-spaces-and-tabs (spaces: line 16, tab: line 4)
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

- The warning is not a deal breaker you can fix that.

OK: The package must be named according to the Package Naming Guidelines
OK: The spec file name must match the base package
OK: The package must meet the Packaging Guidelines
OK: The package must be licensed with a Fedora approved license
OK: The License field in the package spec file must match the actual license
OK: License text included
OK: The spec file must be written in American English
OK: The spec file for the package MUST be legible
OK: The sources used to build the package must match the upstream source

sha1sum openxcap-1.1.2.tar.gz rpmbuild/SOURCES/openxcap-1.1.2.tar.gz 
9ed0917ae69dae7bd8eb05e8d81653cb54a0dea0  openxcap-1.1.2.tar.gz
9ed0917ae69dae7bd8eb05e8d81653cb54a0dea0 
rpmbuild/SOURCES/openxcap-1.1.2.tar.gz

OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture

http://koji.fedoraproject.org/koji/taskinfo?taskID=1784722

N\A: ExcludeArch
OK: All build dependencies must be listed in BuildRequires
N\A: The spec file MUST handle locales properly
N\A: Must call ldconfig in %post and %postun
N\A: If the package is designed to be relocatable
OK: A package must own all directories that it creates
OK: A Fedora package must not list a file more than once
OK: Permissions on files must be set properly
OK: Each package must have a %clean section
FAIL: Each package must consistently use macros

If you are using the %{__python} style macros, then you need to be consistent
and use %{__install}, %{__rm} etc

OK: The package must contain code, or permissable content
N\A: Large documentation files must go in a -doc subpackage
OK: If a package includes something as %doc, it must not affect the runtime of
the application
OK: Header files must be in a -devel package
N\A: Static libraries must be in a -static package
N\A: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
N\A: Library files that end in .so (without suffix) must go in a -devel package
N\A: In the vast majority of cases, devel packages must require the base
package
OK: Packages must NOT contain any .la libtool archives
N\A: Packages containing GUI applications must include a %{name}.desktop file
OK: Packages must not own files or directories already owned by other packages
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
OK: All filenames in rpm packages must be valid UTF-8


- Please fix the issues raised before requesting CVS.

-------------------------------------------------------------------
    This package (openxcap) is APPROVED by topdog
-------------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]