[Bug 532306] Review Request: rubygem-ruby-debug - Faster implementation of the standard Debugging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532306





--- Comment #2 from Jeroen van Meeuwen <kanarip@xxxxxxxxxxx>  2009-11-02 13:51:46 EDT ---
(In reply to comment #1)
> - Please create one srpm per one gem.

These gems do not distribute very well separately, they have the same upstream
and one requires the other in a %{version}-%{release} specific manner.

> - Also, you must not strip rebuilt binaries and create debuginfo rpm
>   correctly. Please refer to:
>  
> https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C

I don't know how to resolve the inclusion of a reference to the buildroot in
the binary blob (I did know how to make it disappear in the included Makefile,
but not the blob):

"""
+ /usr/lib/rpm/check-buildroot
Binary file
/home/jmeeuwen/devel/rpmbuild/BUILDROOT/rubygem-ruby-debug-0.10.3-1.fc12.x86_64/usr/lib64/ruby/site_ruby/1.8/x86_64-linux/ruby_debug.so
matches
Found
'/home/jmeeuwen/devel/rpmbuild/BUILDROOT/rubygem-ruby-debug-0.10.3-1.fc12.x86_64'
in installed files; aborting
error: Bad exit status from /var/tmp/rpm-tmp.eZZmKv (%install)
"""

> - Also unless unavoided I don't think to add || : for test results.
>   If test fails, you should debug it first.  

I've fiddled around with it a bit and it now seems OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]