Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pikloops - Code generator for PIC delays https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208254 ------- Additional Comments From Jochen@xxxxxxxxxxxxxxx 2006-09-27 13:41 EST ------- Good: + Rpmlint doesn't complaint source rpm. + Local build works fine. + Tar ball in source rpm matches with upstream + Local install/uninstall works fine. + Rpmlint of installed rpm doesn't complaints. + Programm starts properly. + Mock build works fine. Bad: - Debuginfo package is empty. - QT environment variable are not sourced. - Desktop file: the Categories tag should contain Application (wiki: PackagingGuidelines#desktop) - Missing dependancy on update-desktop-database for %post (package desktop-file-utils) - Missing dependancy on update-desktop-database for %postun (package desktop-file-utils) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review