Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528010 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-10-30 11:21:18 EDT --- Just a few comments for now: - Don't you want to name it PyMCA? - BR: python-setuptools-devel is not needed, python-setuptools is enought. - get rid of /usr/bin/env: find %{buildroot}%{python_sitearch}/PyMca -name '*.py' | xargs sed -i '/\/usr\/bin\/env/d' is much less noisy, than your for loop and 'seems' to act faster, but your choice ;). The for loop is just necessary, if you want to keep timestamps… Hmm, why don't you? - What do you want to archieve with 'echo yes' in %build and %install? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review