Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484386 Orion Poplawski <orion@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orion@xxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxxxxxxx Flag| |fedora-review? --- Comment #20 from Orion Poplawski <orion@xxxxxxxxxxxxx> 2009-10-29 17:56:45 EDT --- I'll take the review. First comments: Let's change all the %define statements to %global. I'm a little leery about the defaults if pkg-config emacs doesn't work. What's the motivation? Perhaps other conditionals would be more appropriate? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review