Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226522 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |loganjerry@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |loganjerry@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jerry James <loganjerry@xxxxxxxxx> 2009-10-29 13:51:15 EDT --- I will review the F-12 branch. It looks like the F-12 branch is several commits ahead of the devel branch, so that needs to be sorted out. Here is the output of rpmlint on F-12: valgrind.x86_64: W: incoherent-version-in-changelog 3.5.0-6 ['1:3.5.0-6', '1:3.5.0-6'] valgrind.x86_64: W: obsolete-not-provided valgrind-callgrind valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/memcheck-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/memcheck-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/memcheck-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/bin/valgrind-listener valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/cachegrind-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/cachegrind-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/cachegrind-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/exp-bbv-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/exp-bbv-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/exp-bbv-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/exp-ptrcheck-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/exp-ptrcheck-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/exp-ptrcheck-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/drd-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/drd-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/drd-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/lackey-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/lackey-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/lackey-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_massif-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_massif-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/bin/valgrind valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_exp-ptrcheck-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_exp-ptrcheck-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_drd-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_drd-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/none-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/none-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/none-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/bin/no_op_client_for_valgrind valgrind.x86_64: W: unstripped-binary-or-object /usr/bin/cg_merge valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/massif-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/massif-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/massif-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/vgpreload_core-amd64-linux.so valgrind.x86_64: E: shared-lib-without-dependency-information /usr/lib64/valgrind/vgpreload_core-amd64-linux.so valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/callgrind-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/callgrind-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/callgrind-amd64-linux valgrind.x86_64: W: unstripped-binary-or-object /usr/lib64/valgrind/helgrind-amd64-linux valgrind.x86_64: W: ldd-failed /usr/lib64/valgrind/helgrind-amd64-linux valgrind.x86_64: E: statically-linked-binary /usr/lib64/valgrind/helgrind-amd64-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/cachegrind-x86-linux ../../lib/valgrind/cachegrind-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_massif-x86-linux.so ../../lib/valgrind/vgpreload_massif-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_core-x86-linux.so ../../lib/valgrind/vgpreload_core-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/helgrind-x86-linux ../../lib/valgrind/helgrind-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/callgrind-x86-linux ../../lib/valgrind/callgrind-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/memcheck-x86-linux ../../lib/valgrind/memcheck-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_drd-x86-linux.so ../../lib/valgrind/vgpreload_drd-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_memcheck-x86-linux.so ../../lib/valgrind/vgpreload_memcheck-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/massif-x86-linux ../../lib/valgrind/massif-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_exp-ptrcheck-x86-linux.so ../../lib/valgrind/vgpreload_exp-ptrcheck-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/vgpreload_helgrind-x86-linux.so ../../lib/valgrind/vgpreload_helgrind-x86-linux.so valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/lackey-x86-linux ../../lib/valgrind/lackey-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/exp-bbv-x86-linux ../../lib/valgrind/exp-bbv-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/exp-ptrcheck-x86-linux ../../lib/valgrind/exp-ptrcheck-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/drd-x86-linux ../../lib/valgrind/drd-x86-linux valgrind.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/none-x86-linux ../../lib/valgrind/none-x86-linux valgrind-devel.x86_64: W: no-documentation valgrind-devel.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/libreplacemalloc_toolpreload-x86-linux.a ../../lib/valgrind/libreplacemalloc_toolpreload-x86-linux.a valgrind-devel.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/libvex-x86-linux.a ../../lib/valgrind/libvex-x86-linux.a valgrind-devel.x86_64: W: dangling-relative-symlink /usr/lib64/valgrind/libcoregrind-x86-linux.a ../../lib/valgrind/libcoregrind-x86-linux.a valgrind.spec:26: W: unversioned-explicit-obsoletes valgrind-callgrind valgrind.spec:29: E: hardcoded-library-path in /usr/lib/libc.so valgrind.spec:126: W: make-check-outside-check-section make check || : valgrind.spec:147: E: hardcoded-library-path in ../../lib/valgrind/$j valgrind.spec:259: W: macro-in-%changelog %{_prefix} valgrind.spec:352: W: macro-in-%changelog %rip) 2 packages and 1 specfiles checked; 18 errors, 56 warnings. With 74 errors and warnings to get through, let's count from the top, starting at 1, to make references easier. #1 is solved by prefixing the changelog version numbers with "1:". Since the epoch was bumped before version numbers started appearing there, all of the version numbers need this. #2 and #69 are described in https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Renaming.2Freplacing_existing_packages. But I'm confused. The changelog says the Obsoletes was removed, but it is still there. Should it be there or not? #3-#7,#9-#27,#29-#35,#38-#48 are just due to the nature of valgrind, I think, although I would appreciate a comment on that. #8,#28,#36-#37: is it too difficult or impossible to allow debuginfo generation for the binarines in /usr/bin without also allowing it for everything else, too? #49-#64,#66-#68,#72: these really are dangling symlinks. Do they serve some purpose? I'd expect them to be for support of 32-bit binaries on a 64-bit arch, but I don't see an i686 valgrind package in the x86_64 repository. #65: no documentation for the -devel subpackage is fine. #70: I think we can ignore this one, since it just ensure BRs for the 64-bit platforms. #71: Is there some reason for running tests in %build instead of %check? #73-#74: These just need doubled %s to be sure rpm doesn't try to process them. I'd like to get some feedback on the issues raised above before continuing with the full review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review