Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526126 --- Comment #35 from Andrew McNabb <amcnabb@xxxxxxxxxxx> 2009-10-28 00:13:23 EDT --- Wow. You've made tremendous progress. The remaining rpmlint warnings/errors seem to all be false positives, and it looks like it's passing almost all of the regression tests. You mentioned why "test_socket" is failing, but do you know why "test_httpservers" is failing? What's the justification for removing the shebang lines from .py files that aren't executable? In Comment #26, I mentioned a few changes made in the spec file that look upstreamable. Although it's doesn't seem like a high priority issue, upstreaming would probably declutter the spec file a bit. Whenever you think everything looks good, I'd be happy to do some more testing and come up with any final suggestions. However, I'm not an official reviewer. Do we have anyone lined up for the reviewer role? I think the package is just about ready. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review