Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529861 --- Comment #3 from Dan Horák <dan@xxxxxxxx> 2009-10-27 06:01:03 EDT --- (In reply to comment #2) > Thanks for the review. I did the following: > - changed the license to LGPLv2+ (my rpmlint-0.91-1.fc11.noarch did not object > to the previous value at all) I used rpmlint 0.90 on the built rpms. rpmlint should work with the authoritative list of allowed values from the "Licensing" wiki page ... > - added %doc LICENSE to the %files of the main package but the actual license texts (gpl-2.0.txt, lgpl-2.1.txt) + lgpl-relicensing.txt are still missing, please add them > (I am considering moving the %doc README to the -devel package, as the > information written there is mostly developer oriented) yes, moving the README to -devel makes sense to me > - added the %check section to run the tests (altough the package does not > contain a test _suite_ per se, just a bunch of tests without any notion > of how they should be run). Thanks for adding them. Did you check whether they work even in the chrooted build environment? > - as for the shared-lib-calls-exit warning - apparently this is not > an error, but a design decision of the upstream - they call exit(-1) for > every fatal error. I am really not sure that trying to change it is the > task for the packager. The packager should be just aware of the issue and eventually discuss it with the upstream. > Anyway, the new .spec and .src.rpm files are at the same location (i have kept > the release tag at 1, as the previous attempt was not published anywhere in > Fedora). I am still receiving the old srpm, while the spec is updated. Can you check it? Every published iteration of the package (even published here in bugzilla) must have an updated version/release plus a changelog entry with summary of the changes. The reviewer (and the community) can easily check for the changes and it also prevents the issue with the srpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review