Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530374 --- Comment #2 from Sandro Mathys <sm@xxxxxxxxxxxxxxxx> 2009-10-23 18:30:57 EDT --- Hi Ionuț, Thanks for the tips :) Yea, I forgot the .desktop file...I recognized that soon after I uploaded the pkg but I already switched to 'lazy mode' by then ;) Uhm...I was pretty sure I saw GPLv2+ and not GPLv2 but I'll look at it again. About the icons' licensing...didn't notice that and will try to contact upstream about it. The missing BRs sound sane, will add them :) Updating the icon cache...yea, right. I should patch my own rpmlint or rpmbuild or something to always yell 'DON'T FORGET DESKTOP STUFF'...I really always forget about that stuff because I wouldn't miss them myself in daily use ;) Thanks again for those useful corrections :) You really should become a packager...you'd be the better maintainer than me with your first package already ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review