Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526651 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #18 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2009-10-22 10:44:31 EDT --- Just a few comments (I'm no sponsor anyway ;)): rpmlint output is not clean. - Take a look to https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath for the error with rpath - use %configure instead just ./configure - Doesn't the folder /usr/share/xpaint/include/ belongs to /usr/include/xpaint? At least this folder should go into a -devel subpackage. What about the c_scripts folder? It it needed at runtime? - There is a new version upstream (again^^). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review